Lint against the release, and pull the shared files - #53
Merged
Conversation
Same pairing as abap2UI5/samples: render-runtime 0.1.1 sat next to linter 0.2.1 because the published peer range refused the matching pair, not because 0.1 was wanted. Linter 0.2.2 widened the range, so both floors move to ^0.2.2, and @abaplint/cli joins the ^2.120.23 the corpus declares. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Fv6JYeoMYTAfwEaLupTgz5
Same unpinned git dependency as abap2UI5/samples: abaplint cloned the default branch, so the corpus was checked against the framework's development tip while its readers install a release. abaplint.jsonc now pins 1.143.0. Verified: abaplint reports 0 issues over 158 files at the pin. check:pin holds the pin to one release and runs before any install; bump-framework-pin moves it weekly and lints at the new release before opening the pull request. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Fv6JYeoMYTAfwEaLupTgz5
The view-chain-layout skill now describes what all four repositories actually do, and sync-shared is the workflow that will keep these copies current. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Fv6JYeoMYTAfwEaLupTgz5
The workflow asked `github.event.repository.name` for the repository it is running in, and its only triggers are `schedule` and `workflow_dispatch`. A scheduled run carries no repository object, so the name would have come out empty every Tuesday - the manifest call would have produced nothing and the guard right below it would have failed the run. Loud rather than silent, which is why the guard is there, but the feature would never have worked once. GITHUB_REPOSITORY is always set. Verified by running the whole loop by hand against abap2UI5/samples: five shared files resolved and copied, and the only resulting diff is this workflow updating itself - which is the self-syncing behaviour the shared-file entry describes. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Fv6JYeoMYTAfwEaLupTgz5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
Pin the framework to a release. Same unpinned git dependency as abap2UI5/samples: abaplint cloned the default branch, so this corpus was checked against the framework's development tip while its readers install a release.
abaplint.jsoncnow pins1.143.0.New
check:pin(scripts/check-framework-pin.mjs, source in abap2UI5) holds the pin to one release and runs before any install;bump-framework-pin.yamlmoves it weekly and lints at the new release before opening the pull request.sync-shared.yamlpulls this repository's copies of the shared files from abap2UI5 and opens a PR when one moved.The
view-chain-layoutskill is updated: it now describes what all four repositories actually do. This repository had already migrated to the linter'schain-house-layoutrule and deleted its copy ofchain-format.mjs— the skill still called that script "byte-identical in the two sample repositories" and did not mention this repo at all.Plus
@abap2ui5/render-runtime0.1.1 → 0.2.2 (the 0.1 line was an artefact of the peer-range bug fixed in linter 0.2.2) and@abaplint/clialigned on^2.120.23.How to test
npx abaplint abaplint.jsoncat the pin — 0 issues, 158 files.node scripts/check-framework-pin.mjs— green, and negative-tested: a missing"branch"key and two configs naming different releases both fail.Generated by Claude Code